Bug 50171

Summary: LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html is not working even with ORIENTATION_EVENTS enabled
Product: WebKit Reporter: Chang Shu <cshu>
Component: DOMAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, laszlo.gombos, qi.2.zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 32492    
Attachments:
Description Flags
fix patch
none
fix patch 2 none

Chang Shu
Reported 2010-11-29 12:34:53 PST
The above test case has a typo that prevents it working. :) Btw, the feature is currently turned off by default and expects failure result.
Attachments
fix patch (1.29 KB, patch)
2010-11-29 12:38 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
fix patch 2 (7.67 KB, patch)
2010-11-29 14:46 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2010-11-29 12:38:14 PST
Created attachment 75052 [details] fix patch
Laszlo Gombos
Comment 2 2010-11-29 14:27:50 PST
Perhaps we should rename the test as well to create-event-orientationchange*. Otherwise it looks good.
Chang Shu
Comment 3 2010-11-29 14:46:42 PST
Created attachment 75066 [details] fix patch 2 renamed files based on Laszlo's comments.
Laszlo Gombos
Comment 4 2010-11-29 16:35:53 PST
Comment on attachment 75066 [details] fix patch 2 LGTM, r+.
WebKit Commit Bot
Comment 5 2010-11-29 20:29:39 PST
Comment on attachment 75066 [details] fix patch 2 Clearing flags on attachment: 75066 Committed r72873: <http://trac.webkit.org/changeset/72873>
WebKit Commit Bot
Comment 6 2010-11-29 20:29:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.