Summary: | LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html is not working even with ORIENTATION_EVENTS enabled | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chang Shu <cshu> | ||||||
Component: | DOM | Assignee: | Chang Shu <cshu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, laszlo.gombos, qi.2.zhang | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 32492 | ||||||||
Attachments: |
|
Description
Chang Shu
2010-11-29 12:34:53 PST
Created attachment 75052 [details]
fix patch
Perhaps we should rename the test as well to create-event-orientationchange*. Otherwise it looks good. Created attachment 75066 [details]
fix patch 2
renamed files based on Laszlo's comments.
Comment on attachment 75066 [details]
fix patch 2
LGTM, r+.
Comment on attachment 75066 [details] fix patch 2 Clearing flags on attachment: 75066 Committed r72873: <http://trac.webkit.org/changeset/72873> All reviewed patches have been landed. Closing bug. |