Bug 50171 - LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html is not working even with ORIENTATION_EVENTS enabled
Summary: LayoutTests/fast/dom/DeviceOrientation/create-event-onorientationchange.html ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chang Shu
Depends on:
Blocks: 32492
  Show dependency treegraph
Reported: 2010-11-29 12:34 PST by Chang Shu
Modified: 2010-11-29 20:29 PST (History)
3 users (show)

See Also:

fix patch (1.29 KB, patch)
2010-11-29 12:38 PST, Chang Shu
no flags Details | Formatted Diff | Diff
fix patch 2 (7.67 KB, patch)
2010-11-29 14:46 PST, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2010-11-29 12:34:53 PST
The above test case has a typo that prevents it working. :)
Btw, the feature is currently turned off by default and expects failure result.
Comment 1 Chang Shu 2010-11-29 12:38:14 PST
Created attachment 75052 [details]
fix patch
Comment 2 Laszlo Gombos 2010-11-29 14:27:50 PST
Perhaps we should rename the test as well to create-event-orientationchange*. Otherwise it looks good.
Comment 3 Chang Shu 2010-11-29 14:46:42 PST
Created attachment 75066 [details]
fix patch 2

renamed files based on Laszlo's comments.
Comment 4 Laszlo Gombos 2010-11-29 16:35:53 PST
Comment on attachment 75066 [details]
fix patch 2

LGTM, r+.
Comment 5 WebKit Commit Bot 2010-11-29 20:29:39 PST
Comment on attachment 75066 [details]
fix patch 2

Clearing flags on attachment: 75066

Committed r72873: <http://trac.webkit.org/changeset/72873>
Comment 6 WebKit Commit Bot 2010-11-29 20:29:44 PST
All reviewed patches have been landed.  Closing bug.