Summary: | RenderObject::minimumPreferredLogicalWidth() sometimes reports wrong value | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aaron Boodman <aa> | ||||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, hyatt, jamesr, sam | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | OS X 10.5 | ||||||||||||
Attachments: |
|
Description
Aaron Boodman
2010-11-26 17:13:37 PST
Created attachment 74955 [details]
Patch
Created attachment 74956 [details]
Patch
Comment on attachment 74956 [details]
Patch
Whoops :)
Created attachment 75223 [details]
Patch
Comment on attachment 75223 [details]
Patch
r=me
Comment on attachment 75223 [details] Patch Rejecting patch 75223 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 75223]" exit_code: 2 Last 500 characters of output: ommitting to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/rendering/RenderBox.cpp A repository hook failed: Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/6732012 Created attachment 75458 [details]
Patch
Comment on attachment 75458 [details] Patch Rejecting patch 75458 from review queue. aa@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. The commit-queue encountered the following flaky tests while processing attachment 75458 [details]: animations/dynamic-stylesheet-loading.html Please file bugs against the tests. These tests were authored by cmarrin@apple.com. The commit-queue is continuing to process your patch. Comment on attachment 75458 [details] Patch Clearing flags on attachment: 75458 Committed r73245: <http://trac.webkit.org/changeset/73245> All reviewed patches have been landed. Closing bug. |