Bug 50105

Summary:

Make IDBKeyRange match the spec

Product:

WebKit

Reporter:

Jeremy Orlow <jorlow>

Component:

New Bugs

Assignee:

Jeremy Orlow <jorlow>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andreip, hans, steveblock

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

50093

Bug Blocks:

Attachments:

Description	Flags
almost	none
done	steveblock: review+

Jeremy Orlow

Reported 2010-11-26 03:16:20 PST

Remove flags and instead add two booleans for being open.

Attachments
almost (42.08 KB, patch) 2010-11-26 03:17 PST, Jeremy Orlow	no flags	Details Formatted Diff Diff
done (45.97 KB, patch) 2010-11-26 04:28 PST, Jeremy Orlow	steveblock: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jeremy Orlow

Comment 1 2010-11-26 03:17:49 PST

Created attachment 74911 [details] almost needs change log and has one bug in it, but It's 99% there

Hans Wennborg

Comment 2 2010-11-26 04:27:16 PST

Comment on attachment 74911 [details] almost View in context: https://bugs.webkit.org/attachment.cgi?id=74911&action=review > WebCore/inspector/InspectorResourceAgent.cpp:349 > + //m_frontend->setInitialContent(identifier, sourceString, type); What's this?

Jeremy Orlow

Comment 3 2010-11-26 04:28:50 PST

Created attachment 74917 [details] done fixed the bug

Jeremy Orlow

Comment 4 2010-11-26 04:29:31 PST

(In reply to comment #2) > (From update of attachment 74911 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74911&action=review > > > WebCore/inspector/InspectorResourceAgent.cpp:349 > > + //m_frontend->setInitialContent(identifier, sourceString, type); > > What's this? Making Chrome build. It's now removed (and fixed upstream, so I don't need it).

Andrei Popescu

Comment 5 2010-11-26 05:47:49 PST

LGTM

Jeremy Orlow

Comment 6 2010-11-26 08:37:34 PST

Committed r72767: <http://trac.webkit.org/changeset/72767>

Note You need to log in before you can comment on or make changes to this bug.