Bug 50093

Summary: Convert open*Cursor and createIndex over to using OptionsObject
Product: WebKit Reporter: Jeremy Orlow <jorlow>
Component: New BugsAssignee: Jeremy Orlow <jorlow>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andreip, eric, hans, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 50081    
Bug Blocks: 50105    
Attachments:
Description Flags
patch
none
patch steveblock: review+

Jeremy Orlow
Reported 2010-11-25 12:27:33 PST
...
Attachments
patch (23.94 KB, patch)
2010-11-25 12:30 PST, Jeremy Orlow 		no flags
DetailsFormatted DiffDiff
patch (23.43 KB, patch)
2010-11-26 04:30 PST, Jeremy Orlow 		steveblock: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeremy Orlow
Comment 1 2010-11-25 12:30:45 PST
Created attachment 74893 [details] patch
Hans Wennborg
Comment 2 2010-11-26 01:12:22 PST
Comment on attachment 74893 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=74893&action=review Looks good except one nit: > WebCore/storage/IDBIndex.h:32 > +#include "OptionsObject.h" Include order?
Jeremy Orlow
Comment 3 2010-11-26 04:30:50 PST
Created attachment 74919 [details] patch fixed
Andrei Popescu
Comment 4 2010-11-26 04:56:14 PST
LGTM
Steve Block
Comment 5 2010-11-26 05:18:01 PST
Comment on attachment 74919 [details] patch r=me
Jeremy Orlow
Comment 6 2010-11-26 08:33:49 PST
Committed r72766: <http://trac.webkit.org/changeset/72766>
WebKit Review Bot
Comment 7 2010-11-26 08:52:02 PST
http://trac.webkit.org/changeset/72766 might have broken Chromium Linux Release
Note You need to log in before you can comment on or make changes to this bug.