Bug 50091 – [Qt] Passing multiple layout tests to DumpRenderTree doesn't work

• Component: Tools / Tests
• Status: RESOLVED INVALID

[Robert Hogan]

For me, emitting done() results in the test dumping, resetting and loading the next test before m_hasDumped is reset to true.

Does this happen for anyone else?

[Robert Hogan]

Created attachment 74892 [details]
Patch

[Csaba Osztrogonác]

(In reply to comment #1)
> Created an attachment (id=74892) [details]
> Patch

It doesn't fix the bug for me. :(

$ WebKitBuild/Debug/bin/DumpRenderTree animations/animation-controller-drt-api.html animations/animation-css-rule-types.html
--> DRT still hangs after dumping the rendertree of the first test

[Robert Hogan]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=74892) [details] [details]
> > Patch
> 
> It doesn't fix the bug for me. :(
> 
> $ WebKitBuild/Debug/bin/DumpRenderTree animations/animation-controller-drt-api.html animations/animation-css-rule-types.html
> --> DRT still hangs after dumping the rendertree of the first test

The plot thickens. I tried the patch on the QBAT VM and it worked well. But both here and on the VM I used the Release binary.

[Robert Hogan]

This also works for me on a debug build. So I don't know why we're getting different results.

[Eric Seidel (no email)]

Comment on attachment 74892 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74892&action=review

OK.

> WebKitTools/ChangeLog:10
> +        https://bugs.webkit.org/show_bug.cgi?id=50091

Normally this is right under the bug title (at least when webkit-patch/prepare-ChangeLog fills it in for you).

[Robert Hogan]

Comment on attachment 74892 [details]
Patch

Hi Eric,
Should have removed the review flag since Ossy and I get different results with it, so not safe to land.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.