Bug 50069 – MathML: code cleaning needed in MathMLInlineContainerElement.cpp

• Component: MathML
• Status: RESOLVED FIXED

[François Sausset]

remove unnecessary namespace & style adjustments

[François Sausset]

Created attachment 74859 [details]
Patch

[Daniel Bates]

Comment on attachment 74859 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74859&action=review

Thank you for cleaning this up. I have some minor nits.

> WebCore/ChangeLog:6
> +        Remove unnecessary namespace & style adjustments
> +        https://bugs.webkit.org/show_bug.cgi?id=50069

Disregarding the name/date, Reviewed by, and changed files lines, the formatting convention of a change log entry is bug title; bug URL; then bug description. And the bug description should be a full sentence.

So, the change log for this patch should have the form:

...
MathML: code cleaning needed in MathMLInlineContainerElement.cpp
https://bugs.webkit.org/show_bug.cgi?id=50069

Remove unnecessary namespace & style adjustments.
...

See <http://webkit.org/coding/contributing.html#changelogs> as well as the referenced example <http://trac.webkit.org/changeset/43259>.

> WebCore/mathml/MathMLInlineContainerElement.cpp:82
>          return new (arena) RenderMathMLBlock(this);

Please un-indent this line of code so that it left-aligns with respect to the line "if (hasLocalName(mfencedTag))".

[François Sausset]

Created attachment 74907 [details]
Revised patch

I just modified the log entry and removed the unnecessary tabulation.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74907 [details]:

java/lc3/JSObject/ToObject-001.html
fast/profiler/throw-exception-from-eval.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74907 [details]
Revised patch

Clearing flags on attachment: 74907

Committed r72773: <http://trac.webkit.org/changeset/72773>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.