Bug 50049 – [Qt] Add SelectAll option to the context menu for the editor

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Yi Shen]

When context menu pops up on the editor like textarea, user can use the selectall option to select all the text in the editor

[Yi Shen]

Created attachment 74828 [details]
proposal fix

[Early Warning System Bot]

Attachment 74828 [details] did not build on qt:
Build output: http://queues.webkit.org/results/6318039

[Yi Shen]

Created attachment 74890 [details]
fix webkit2 build

[Eric Seidel (no email)]

Is this a standard Qt context menu option?

[Yi Shen]

(In reply to comment #4)
> Is this a standard Qt context menu option?
I think so. I tried some applications in the qtdemo on linux, and I can see the select all option in the context menu for all the editable component.

[Kenneth Rohde Christiansen]

Comment on attachment 74890 [details]
fix webkit2 build

View in context: https://bugs.webkit.org/attachment.cgi?id=74890&action=review

mac also seems to have this for TextArea and input fields, so r=me

> WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:302
> +    notImplemented();
> +    return "Select All";

Why does this have notImplemented???

[WebKit Commit Bot]

Comment on attachment 74890 [details]
fix webkit2 build

Rejecting attachment 74890 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 74890]" exit_code: 2
Last 500 characters of output:
-------------------------
|Index: WebKitTools/QtTestBrowser/mainwindow.cpp
|===================================================================
|--- WebKitTools/QtTestBrowser/mainwindow.cpp	(revision 72736)
|+++ WebKitTools/QtTestBrowser/mainwindow.cpp	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/7272148

[Eric Seidel (no email)]

Sorry, WebKitTools recently got renamed to Tools.  There has been some discussion of modifying svn-apply to be able to fix patches during apply, but until that happens we need to fix this patch manually to apply to Tools instead of WebKitTools.

[Yi Shen]

(In reply to comment #8)
> Sorry, WebKitTools recently got renamed to Tools.  There has been some discussion of modifying svn-apply to be able to fix patches during apply, but until that happens we need to fix this patch manually to apply to Tools instead of WebKitTools.

Eric, thanks for your explanation :)

[Yi Shen]

Created attachment 77835 [details]
fix the commit bot issue casued by folder name change

[WebKit Commit Bot]

Comment on attachment 77835 [details]
fix the commit bot issue casued by folder name change

Clearing flags on attachment: 77835

Committed r74941: <http://trac.webkit.org/changeset/74941>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/74941 might have broken Windows Release (Build) and Windows Debug (Build)

[Benjamin Poulain]

I have mixed feeling about this patch. I am affraid that will cause existing apps to have the item "select all" two times in their menu.

Yi, would you mind checking the code of Konqueror, Rekonq and Arora regarding this?

[Yi Shen]

(In reply to comment #14)
> I have mixed feeling about this patch. I am affraid that will cause existing apps to have the item "select all" two times in their menu.
> 
> Yi, would you mind checking the code of Konqueror, Rekonq and Arora regarding this?

Hi Benjamin Poulain, I will check it and let you know.

[Yi Shen]

(In reply to comment #14)
> I have mixed feeling about this patch. I am affraid that will cause existing apps to have the item "select all" two times in their menu.
> 
> Yi, would you mind checking the code of Konqueror, Rekonq and Arora regarding this?

Sorry for late reply. I tested Arora and didn't see any problem. (Sorry, I don't have KDE env to run Konqueror,Rekonq). Benjamin Poulain, let me know if you think it is still necessary to test Konqueror and Rekonq as well.

[Benjamin Poulain]

(In reply to comment #16)
> Sorry for late reply. I tested Arora and didn't see any problem. (Sorry, I don't have KDE env to run Konqueror,Rekonq). Benjamin Poulain, let me know if you think it is still necessary to test Konqueror and Rekonq as well.

I mentioned the problem to the devs of Rekonq. That should be ok.

Lets hope no other big projects rely on this kind of specific behavior so the patch does not cause too many problems.