Bug 50034

Summary: [GTK] Make kit() methods return the proper type instead of gpointer
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
kit.diff none

Xan Lopez
Reported 2010-11-24 11:05:22 PST
Saves us quite a bit of mindless casting.
Attachments
kit.diff (15.09 KB, patch)
2010-11-24 11:10 PST, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-11-24 11:10:24 PST
Created attachment 74780 [details] kit.diff
Martin Robinson
Comment 2 2010-11-24 11:12:25 PST
Comment on attachment 74780 [details] kit.diff Awesome!
WebKit Review Bot
Comment 3 2010-11-24 11:12:31 PST
Attachment 74780 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebCore/ChangeLog', u'WebCore/bindings/gobject/WebKitDOMBinding.cpp', u'WebCore/bindings/gobject/WebKitDOMBinding.h', u'WebCore/bindings/scripts/CodeGeneratorGObject.pm', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'WebKit/gtk/webkit/webkitprivate.cpp', u'WebKit/gtk/webkit/webkitwebview.cpp']" exit_code: 1 WebCore/bindings/gobject/WebKitDOMBinding.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 4 2010-12-14 01:34:02 PST
Seems like this just needs a small style update and landing.
Xan Lopez
Comment 5 2010-12-14 04:29:48 PST
Comment on attachment 74780 [details] kit.diff This landed in r72691, my apologies for not closing the bug.
Xan Lopez
Comment 6 2010-12-14 04:29:59 PST
Closing.
Note You need to log in before you can comment on or make changes to this bug.