Bug 50024

Summary: [WK2] Support repeating timers
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Balazs Kelemen
Reported 2010-11-24 07:51:29 PST
Our RunLoop::Timer implementation lacks support for repeating timers. Let's fix this.
Attachments
Patch (2.33 KB, patch)
2010-11-24 07:57 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Patch (6.30 KB, patch)
2010-11-26 07:09 PST, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-11-24 07:57:15 PST
Created attachment 74760 [details] Patch
Andreas Kling
Comment 2 2010-11-24 13:19:28 PST
Comment on attachment 74760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74760&action=review > WebKit2/Platform/qt/RunLoopQt.cpp:116 > + ASSERT(!repeatInterval || nextFireInterval == repeatInterval); Hmm. This seems mysterious. Will nextFireInterval always == repeatInterval for repeat timers? If so, this function should be changed to take a "bool isSingleShot" instead of a second interval IMO.
Balazs Kelemen
Comment 3 2010-11-25 07:15:01 PST
(In reply to comment #2) > (From update of attachment 74760 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74760&action=review > > > WebKit2/Platform/qt/RunLoopQt.cpp:116 > > + ASSERT(!repeatInterval || nextFireInterval == repeatInterval); > > Hmm. This seems mysterious. Will nextFireInterval always == repeatInterval for repeat timers? > If so, this function should be changed to take a "bool isSingleShot" instead of a second interval IMO. Right. I would not like to touch the common part, but that was not the right decision.
Balazs Kelemen
Comment 4 2010-11-25 16:30:50 PST
Should be fixed on Windows as well.
Balazs Kelemen
Comment 5 2010-11-26 07:09:36 PST
Created attachment 74938 [details] Patch
Balazs Kelemen
Comment 6 2010-11-29 11:44:55 PST
Comment on attachment 74938 [details] Patch Clearing flags on attachment: 74938 Committed r72816: <http://trac.webkit.org/changeset/72816>
Balazs Kelemen
Comment 7 2010-11-29 11:45:04 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.