Bug 49983

Summary: Remove Bakefile build system files
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, kevino
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 34022    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Patrick R. Gansterer
Reported 2010-11-23 10:48:16 PST
see patch
Attachments
Patch (8.43 KB, patch)
2010-11-23 10:52 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-11-23 10:52:25 PST
Created attachment 74682 [details] Patch r53757 only removed the content, but not the files. This patch removes that empty files.
Csaba Osztrogonác
Comment 2 2010-11-24 04:26:07 PST
Comment on attachment 74682 [details] Patch r=me, but please mention in changelogs that "r53757 only removed the content, but not the files. This patch removes that empty files." And add changelog entry to WebKit directory too.
Patrick R. Gansterer
Comment 3 2010-11-24 07:39:58 PST
Comment on attachment 74682 [details] Patch Clearing flags on attachment: 74682 Manually committed r72669: <http://trac.webkit.org/changeset/72669>
Patrick R. Gansterer
Comment 4 2010-11-24 07:40:20 PST
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 5 2010-12-21 00:30:41 PST
When this was committed, it added a non-utf8 character to WebKit/wx/ChangeLog. Which caused issues when processing bug 51382. At least I think it was from this change.
Patrick R. Gansterer
Comment 6 2010-12-21 01:06:32 PST
(In reply to comment #5) > When this was committed, it added a non-utf8 character to WebKit/wx/ChangeLog. Which caused issues when processing bug 51382. At least I think it was from this change. Seams that there was no non-ascii character in the file before and i commited it with the wrong encoding. Sorry. Can we add a svn pre commit hook on text files to avoid such problems?
Note You need to log in before you can comment on or make changes to this bug.