Summary: | First steps to adding web audio files to build systems | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rogers <crogers> | ||||||||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | abecsi, commit-queue, dglazkov, eric, gustavo, kbr, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | Other | ||||||||||||||||
OS: | OS X 10.5 | ||||||||||||||||
Attachments: |
|
Description
Chris Rogers
2010-11-22 18:32:28 PST
Created attachment 74624 [details]
Patch
Attachment 74624 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6365008 Attachment 74624 [details] did not build on qt: Build output: http://queues.webkit.org/results/6357010 Attachment 74624 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6357012 Attachment 74624 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6385007 Comment on attachment 74624 [details]
Patch
Still needs some more work to iron out build issues.
Created attachment 75204 [details]
Patch
Still not quite ready, and some of this can probably be split out into a separate patch, but I'd like to see how the buildbots react... Attachment 75204 [details] did not build on qt: Build output: http://queues.webkit.org/results/6409104 Created attachment 75212 [details]
Patch
Attachment 75212 [details] did not build on qt: Build output: http://queues.webkit.org/results/6395122 (In reply to comment #11) > Attachment 75212 [details] did not build on qt: > Build output: http://queues.webkit.org/results/6395122 Please add the idl files to WebCore.pri, or disable WEB_AUDIO on Qt by adding a !contains(DEFINES, ENABLE_WEB_AUDIO=.): DEFINES += ENABLE_WEB_AUDIO=0 to WebCore/features.pri Created attachment 75310 [details]
Patch
Andras, thanks for the tip. I've uploaded a new patch to disable WEB_AUDIO for now on Qt. Attachment 75310 [details] did not build on qt: Build output: http://queues.webkit.org/results/6676007 Created attachment 75314 [details]
Patch
New patch also adds .idl files to WebCore.pri for Qt. (In reply to comment #17) > New patch also adds .idl files to WebCore.pri for Qt. Thanks very much for doing that. Seems that the generated sources from IDL do not have guards for web audio. Is there a way to add ENABLE guards to an IDL file's includes? The patch looks pretty straightforward altogether, however I'm not a reviewer. Created attachment 75399 [details]
Patch
Andras, the IDL glue generation script could maybe be refined to handle this. But, it's good to get the IDL files in the build systems. This new patch removes the AudioContext changes since these were landed in a different patch: http://trac.webkit.org/changeset/73174 Comment on attachment 75399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=75399&action=review Looks good as much as can be determined without trying builds on all platforms. r=me with one issue addressed. > WebCore/WebCore.gyp/WebCore.gyp:149 > + '../platform/audio/win', The mac and win include directories should be added in the OS-specific blocks further below this one. Comment on attachment 75399 [details] Patch Rejecting patch 75399 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75399]" exit_code: 2 Last 500 characters of output: j patching file WebCore/WebCore.pri patching file WebCore/WebCore.pro patching file WebCore/features.pri patching file WebCore/ForwardingHeaders/wtf/Complex.h patching file WebCore/WebCore.gyp/WebCore.gyp patching file WebCore/bindings/js/JSDOMWindowCustom.cpp patching file WebCore/page/DOMWindow.idl patching file WebCore/platform/audio/HRTFElevation.cpp Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/6716030 Committed r73283: <http://trac.webkit.org/changeset/73283> |