Bug 49946

Summary:

[chromium] Implement Extensions3DChromium::getGraphicsResetStatusARB

Product:

WebKit

Reporter:

Alexey Marinichev <amarinichev>

Component:

WebKit Misc.

Assignee:

Alexey Marinichev <amarinichev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kbr

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB	none
fix build break	none

Alexey Marinichev

Reported 2010-11-22 16:10:25 PST

This extension helps with lost context recovery.

Attachments
Patch (5.65 KB, patch) 2010-11-22 16:20 PST, Alexey Marinichev	no flags	Details Formatted Diff Diff
changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB (5.65 KB, patch) 2010-11-22 16:32 PST, Alexey Marinichev	no flags	Details Formatted Diff Diff
fix build break (5.69 KB, patch) 2010-11-22 16:48 PST, Alexey Marinichev	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Alexey Marinichev

Comment 1 2010-11-22 16:20:28 PST

Created attachment 74610 [details] Patch

Kenneth Russell

Comment 2 2010-11-22 16:29:18 PST

Comment on attachment 74610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74610&action=review This basically looks good but there's one minor semantic bug. > WebKit/chromium/src/Extensions3DChromium.cpp:53 > + return m_internal->isContextLost() ? GraphicsContext3D::CONTEXT_LOST_WEBGL : GraphicsContext3D::NO_ERROR; This should be returning one of NO_ERROR, GUILTY_CONTEXT_RESET_ARB, INNOCENT_CONTEXT_RESET_ARB, or UNKNOWN_CONTEXT_RESET_ARB. Since it sounds like we can't make the determination yet it should probably be UNKNOWN_CONTEXT_RESET_ARB. > WebKit/chromium/src/WebGraphicsContext3DDefaultImpl.cpp:992 > + return false; Should we add a FIXME to implement this?

Alexey Marinichev

Comment 3 2010-11-22 16:32:27 PST

Created attachment 74611 [details] changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB

Kenneth Russell

Comment 4 2010-11-22 16:35:45 PST

Comment on attachment 74611 [details] changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB Looks good.

Kenneth Russell

Comment 5 2010-11-22 16:40:50 PST

Comment on attachment 74611 [details] changed CONTEXT_LOST_WEBGL to UNKNOWN_CONTEXT_RESET_ARB Apparently there's a build failure with this version of the patch. Attempting to get it out of the commit queue (though hopefully it will just be rejected).

Alexey Marinichev

Comment 6 2010-11-22 16:48:03 PST

Created attachment 74613 [details] fix build break

Kenneth Russell

Comment 7 2010-11-22 16:49:49 PST

Comment on attachment 74613 [details] fix build break OK.

WebKit Commit Bot

Comment 8 2010-11-22 23:44:15 PST

Comment on attachment 74613 [details] fix build break Clearing flags on attachment: 74613 Committed r72587: <http://trac.webkit.org/changeset/72587>

WebKit Commit Bot

Comment 9 2010-11-22 23:44:20 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.