Bug 49919

Summary: [Qt] GraphicsContext: Clean up Qt/WebCore type conversion functions
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Renata Hodovan <rhodovan.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal Keywords: Qt, QtTriaged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch kling: review+

Andreas Kling
Reported 2010-11-22 09:35:57 PST
There are a bunch of conversion functions between Qt and WebCore types at the top of GraphicsContext.cpp All cases should be handled in all functions, instead of having a qWarning() and returning some arbitrary "sane default". Also, Qt::MiterJoin shouldn't be used anywhere (it's currently impossibly returned by toQtLineJoin().)
Attachments
Patch (2.64 KB, patch)
2010-11-24 06:57 PST, Renata Hodovan 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Renata Hodovan
Comment 1 2010-11-24 06:57:34 PST
Created attachment 74755 [details] Patch
Andreas Kling
Comment 2 2010-11-24 06:58:56 PST
Comment on attachment 74755 [details] Patch LGTM
Andreas Kling
Comment 3 2010-11-24 07:49:23 PST
Landed in <http://trac.webkit.org/changeset/72668>
Note You need to log in before you can comment on or make changes to this bug.