Bug 49903

Summary: [GTK] Inspector: add a way to inspect a WebKitDOMNode
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Add webkit_web_inspector_inspect()
xan.lopez: review-
Updated patch using inspect_node() and fixing includes none

Carlos Garcia Campos
Reported 2010-11-22 04:26:41 PST
Add API to WebKitWebInspector to inspect a node.
Attachments
Add webkit_web_inspector_inspect() (2.43 KB, patch)
2010-11-22 04:30 PST, Carlos Garcia Campos 		xan.lopez: review-
DetailsFormatted DiffDiff
Updated patch using inspect_node() and fixing includes (2.46 KB, patch)
2010-11-25 00:58 PST, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2010-11-22 04:30:29 PST
Created attachment 74539 [details] Add webkit_web_inspector_inspect()
Martin Robinson
Comment 2 2010-11-23 22:25:19 PST
Seems reasonable to me. Maybe webkit_web_inspector_inspect_node? We'll need one or two more GTK+ reviewers to approve the API change.
Xan Lopez
Comment 3 2010-11-24 03:52:19 PST
Comment on attachment 74539 [details] Add webkit_web_inspector_inspect() View in context: https://bugs.webkit.org/attachment.cgi?id=74539&action=review > WebKit/gtk/webkit/webkitwebinspector.cpp:504 > + * @web_inspector: the #WebKitWebInspector that will do the inspection inspect_node would be better, I agree with Martin. > WebKit/gtk/webkit/webkitwebinspector.h:26 > #include <webkit/webkitdefines.h> You shouldn't include the whole dom header just to use WebKitDOMNode*. Including webkitdomdefines.h should be enough, I think.
Carlos Garcia Campos
Comment 4 2010-11-25 00:58:32 PST
Created attachment 74838 [details] Updated patch using inspect_node() and fixing includes
WebKit Commit Bot
Comment 5 2010-11-26 09:43:16 PST
Comment on attachment 74838 [details] Updated patch using inspect_node() and fixing includes Clearing flags on attachment: 74838 Committed r72772: <http://trac.webkit.org/changeset/72772>
WebKit Commit Bot
Comment 6 2010-11-26 09:43:21 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.