Bug 49895

Summary: Add lastModifiedDate attribute to File interface per File API spec
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: Jian Li <jianli>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dimich, eric, gustavo, jarred, levin, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed Patch
jianli: commit-queue-
Proposed Patch
jianli: commit-queue-
Proposed Patch levin: review+, jianli: commit-queue-

Description Jian Li 2010-11-21 20:06:35 PST 
Add lastModifiedDate attribute to File interface per File API spec:
Comment 1 Jian Li 2010-11-21 20:39:41 PST 
Created attachment 74527 [details]
Proposed Patch
Comment 2 WebKit Review Bot 2010-11-21 20:51:14 PST 
Attachment 74527 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6251084
Comment 3 Jian Li 2010-11-21 21:15:11 PST 
Created attachment 74529 [details]
Proposed Patch

Fixed gtk error.
Comment 4 WebKit Review Bot 2010-11-21 21:24:00 PST 
Attachment 74529 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/6165136
Comment 5 Jian Li 2010-11-21 21:47:11 PST 
Created attachment 74530 [details]
Proposed Patch
Comment 6 Jarred Nicholls 2010-12-12 22:38:46 PST 
The spec calls for lastModifiedDate to be a DOMString, not a Date.  It wants a "valid date string":

http://dev.w3.org/html5/spec/Overview.html#valid-date-string

Or in otherwords, YYYY-MM-DD
Comment 7 Jian Li 2010-12-20 13:38:13 PST 
(In reply to comment #6)
> The spec calls for lastModifiedDate to be a DOMString, not a Date.  It wants a "valid date string":
> 
> http://dev.w3.org/html5/spec/Overview.html#valid-date-string
> 
> Or in otherwords, YYYY-MM-DD

The spec has just been updated with a Date object returned for File.lastModifiedData.
http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate
Comment 8 Jarred Nicholls 2010-12-20 13:41:00 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > The spec calls for lastModifiedDate to be a DOMString, not a Date.  It wants a "valid date string":
> > 
> > http://dev.w3.org/html5/spec/Overview.html#valid-date-string
> > 
> > Or in otherwords, YYYY-MM-DD
> 
> The spec has just been updated with a Date object returned for File.lastModifiedData.
> http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate

Indeed, good.  When will that be the latest published version you think?
Comment 9 Jian Li 2010-12-20 17:36:33 PST 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > The spec calls for lastModifiedDate to be a DOMString, not a Date.  It wants a "valid date string":
> > > 
> > > http://dev.w3.org/html5/spec/Overview.html#valid-date-string
> > > 
> > > Or in otherwords, YYYY-MM-DD
> > 
> > The spec has just been updated with a Date object returned for File.lastModifiedData.
> > http://dev.w3.org/2006/webapi/FileAPI/#dfn-lastModifiedDate
> 
> Indeed, good.  When will that be the latest published version you think?

Please ping the spec editor about this. Thanks.
Comment 10 Jian Li 2010-12-20 18:22:49 PST 
Committed as http://trac.webkit.org/changeset/74380.
Comment 11 WebKit Review Bot 2010-12-20 19:10:43 PST 
http://trac.webkit.org/changeset/74380 might have broken GTK Linux 64-bit Debug