Bug 49894

Summary: Remove StringImpl::computeHash()
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Web Template FrameworkAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, eric, gustavo, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 49893, 52934    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2010-11-21 18:50:22 PST
see patch
Attachments
Patch (9.57 KB, patch)
2010-11-21 19:18 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.88 KB, patch)
2011-03-19 05:06 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-11-21 19:18:04 PST
Created attachment 74525 [details] Patch
Eric Seidel (no email)
Comment 2 2010-11-21 19:32:19 PST
Attachment 74525 [details] did not build on mac: Build output: http://queues.webkit.org/results/6255090
Early Warning System Bot
Comment 3 2010-11-21 19:38:42 PST
Attachment 74525 [details] did not build on qt: Build output: http://queues.webkit.org/results/6276042
WebKit Review Bot
Comment 4 2010-11-21 19:53:27 PST
Attachment 74525 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6187110
Build Bot
Comment 5 2010-11-21 23:54:54 PST
Attachment 74525 [details] did not build on win: Build output: http://queues.webkit.org/results/6218122
Eric Seidel (no email)
Comment 6 2010-11-22 09:07:29 PST
It seems you should CC some of the original authors. Webkit patch's suggest-reviewers functions can help with that.
Eric Seidel (no email)
Comment 7 2010-12-12 02:41:19 PST
Comment on attachment 74525 [details] Patch Does not compile.
Patrick R. Gansterer
Comment 8 2011-03-19 05:06:06 PDT
Created attachment 86260 [details] Patch
WebKit Review Bot
Comment 9 2011-03-19 05:09:11 PDT
Attachment 86260 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/text/StringImpl.h:238: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 10 2011-03-19 17:57:22 PDT
Comment on attachment 86260 [details] Patch Clearing flags on attachment: 86260 Committed r81563: <http://trac.webkit.org/changeset/81563>
WebKit Commit Bot
Comment 11 2011-03-19 17:57:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.