Summary: | Use WTF_ARRAY_LENGTH in WebCore directory | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Patrick R. Gansterer <paroga> | ||||||||||
Component: | WebCore Misc. | Assignee: | Patrick R. Gansterer <paroga> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, dglazkov, eric, gustavo, ossy, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Patrick R. Gansterer
2010-11-21 09:39:00 PST
Created attachment 74507 [details]
Patch
Attachment 74507 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6274043 Attachment 74507 [details] did not build on qt: Build output: http://queues.webkit.org/results/6246088 Created attachment 74508 [details]
Patch
Attachment 74507 [details] did not build on mac: Build output: http://queues.webkit.org/results/6246089 Attachment 74507 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6128104 Attachment 74508 [details] did not build on gtk: Build output: http://queues.webkit.org/results/6217127 Attachment 74507 [details] did not build on win: Build output: http://queues.webkit.org/results/6118106 Attachment 74508 [details] did not build on qt: Build output: http://queues.webkit.org/results/6144106 Created attachment 74509 [details]
Patch
Attachment 74508 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6257080 Created attachment 74510 [details]
Patch
Attachment 74507 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6164119 Attachment 74508 [details] did not build on chromium: Build output: http://queues.webkit.org/results/6141110 Comment on attachment 74510 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74510&action=review > WebCore/html/canvas/WebGLBuffer.cpp:182 > + size_t numEntries = WTF_ARRAY_LENGTH(m_maxIndexCache); > + for (size_t i = 0; i < numEntries; ++i) We don't need numEntries variable here. Please fix this before landing: for (size_t i = 0; i < WTF_ARRAY_LENGTH(m_maxIndexCache); ++i) Otherwise LGTM. Comment on attachment 74510 [details] Patch (In reply to comment #15) > (From update of attachment 74510 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=74510&action=review > > > WebCore/html/canvas/WebGLBuffer.cpp:182 > > + size_t numEntries = WTF_ARRAY_LENGTH(m_maxIndexCache); > > + for (size_t i = 0; i < numEntries; ++i) > > We don't need numEntries variable here. Please fix this before landing: > for (size_t i = 0; i < WTF_ARRAY_LENGTH(m_maxIndexCache); ++i) > > Otherwise LGTM. I removed numEntries in a first version, but the compiled said NO ;-) It's used in http://trac.webkit.org/browser/trunk/WebCore/html/canvas/WebGLBuffer.cpp?rev=68424#L190. (In reply to comment #16) > I removed numEntries in a first version, but the compiled said NO ;-) > It's used in http://trac.webkit.org/browser/trunk/WebCore/html/canvas/WebGLBuffer.cpp?rev=68424#L190. Ooops, you're right. :) Comment on attachment 74510 [details] Patch Clearing flags on attachment: 74510 Committed r72500: <http://trac.webkit.org/changeset/72500> All reviewed patches have been landed. Closing bug. |