Summary: | [windows] font-size:0 text runs should have zero width | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, dglazkov, eric, fishd, hyatt, mihaip, pravind.2k4, senorblanco | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
URL: | http://www.php.net/manual/en/function.session-decode.php | ||||||
Attachments: |
|
Description
James Robinson
2010-11-20 16:20:24 PST
Created attachment 74601 [details]
patch for chromium
Here's a patch for the chromium SimpleFont* classes that need them. The OS X code seems to all work fine. I'm pretty positive that the Safari Win port needs a similar patch, but I'm not sure exactly how to handle boundsForGDIGlyph() and don't have access to a dev environment to test code changes on Safari/Win so I've left that codepath alone. Comment on attachment 74601 [details]
patch for chromium
please don't break everything when landing this.
Committed r72567: <http://trac.webkit.org/changeset/72567> (In reply to comment #2) > I'm pretty positive that the Safari Win port needs a similar patch, but I'm not sure exactly how to handle boundsForGDIGlyph() I think you can handle it just like the other width functions. BTW, the updated test fails on the upstream Mac port on Leopard (presumably an ATSUI vs. CoreText difference): -PASS s.getBoundingClientRect().width is 0 +FAIL s.getBoundingClientRect().width should be 0. Was 2147483648. http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r72675%20(23809)/results.html Seems this should be closed? The same behavior is seen on Safari windows. Please reopen the bug. I'm uploading the patch for the same. |