Bug 49870

Summary:

[Qt] Dragging a selection should use a rendering of the selection as "cursor" for the drag

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebCore Misc.

Assignee:

QtWebKit Unassigned <webkit-qt-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

49872

Attachments:

Description	Flags
Proposed patch	none

Andreas Kling

Reported 2010-11-20 14:52:14 PST

We need to implement Frame::dragImageForSelection() and hook it up in DragClientQt::startDrag()

Attachments
Proposed patch (4.75 KB, patch) 2010-11-20 15:03 PST, Andreas Kling	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2010-11-20 15:03:00 PST

Created attachment 74488 [details] Proposed patch

Antonio Gomes

Comment 2 2010-11-20 22:28:22 PST

Comment on attachment 74488 [details] Proposed patch r=me. I assume it can't be tested :(

Andreas Kling

Comment 3 2010-11-20 22:33:56 PST

(In reply to comment #2) > I assume it can't be tested :( Indeed ;( But thanks for reviewing!

Andreas Kling

Comment 4 2010-11-20 22:36:45 PST

Comment on attachment 74488 [details] Proposed patch Clearing flags on attachment: 74488 Committed r72494: <http://trac.webkit.org/changeset/72494>

Andreas Kling

Comment 5 2010-11-20 22:36:55 PST

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 6 2010-11-20 22:57:51 PST

http://trac.webkit.org/changeset/72494 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html

Note You need to log in before you can comment on or make changes to this bug.