Bug 49814

Summary:

Don't check for constant registers when we can guarantee that the register won't be in the constant pool

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

New Bugs

Assignee:

Oliver Hunt <oliver>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	ggaren: review+

Description Oliver Hunt 2010-11-19 11:02:41 PST

Don't check for constant registers when we can guarantee that the register won't be in the constant pool

Comment 1 Oliver Hunt 2010-11-19 11:08:27 PST

Created attachment 74405 [details]
Patch

Comment 2 Darin Adler 2010-11-19 11:25:27 PST

Comment on attachment 74405 [details]
Patch

Don’t we want an assertion in debug builds?

Comment 3 Geoffrey Garen 2010-11-19 12:38:19 PST

+        Add uncheckedR(int) to CallFrame, and replace all the uses of r() with uncheckedR().

You didn't replace all uses -- just the known non-constant uses.

Comment 4 Geoffrey Garen 2010-11-19 12:38:38 PST

Comment on attachment 74405 [details]
Patch

r=me on a patch that fixes these two issues.

Comment 5 Oliver Hunt 2010-11-19 14:44:19 PST

Committed r72442: <http://trac.webkit.org/changeset/72442>