Bug 49664 – [Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

The #defines for ENABLE_TOUCH_EVENT seem a bit chaotic. It looks like the library would not compile.

[Benjamin Poulain]

Created attachment 74114 [details]
Patch

[Laszlo Gombos]

Comment on attachment 74114 [details]
Patch

LGTM, r+. Laszlo

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74114 [details]:

fast/loader/recursive-before-unload-crash.html
fast/dom/onerror-img.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74114 [details]
Patch

Rejecting patch 74114 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
itBuild/Debug/WebProcess.app /Projects/CommitQueue/WebKitBuild/Debug/WebKit2.framework

** BUILD FAILED **


The following build commands failed:
WebKit2:
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Debug/WebKit2.build/Objects-normal/x86_64/WebKeyboardEvent.o /Projects/CommitQueue/WebKit2/Shared/WebKeyboardEvent.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(1 failure)

Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81.

Full output: http://queues.webkit.org/results/6178063

[Benjamin Poulain]

Comment on attachment 74114 [details]
Patch

cq+, this patch has nothing to do with the build failure on Mac.

[WebKit Commit Bot]

Comment on attachment 74114 [details]
Patch

Clearing flags on attachment: 74114

Committed r72305: <http://trac.webkit.org/changeset/72305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Odd.  I'm not sure how the cq got confused like that.  It should have tried to build again and failed and then not commented.  I've not seen it have a false-positive build failure in a long long time.