Bug 49660

Summary: Clear the speech input mock explicitly before each test.
Product: WebKit Reporter: Satish Sampath <satish>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jorlow, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch jorlow: review+

Satish Sampath
Reported 2010-11-17 06:34:21 PST
In DRT, the speech input mock is currently held by LayoutTestController and when a mock result is set the value stays as is across all subsequent tests until overwritten. In preparation for a future CL where we'll be having a list of mock results instead of just 1, I'm adding a 'clearResults' method to the mock and invoking it before each test. This also required moving the mock from LayoutTestController to WebViewHost because WebViewHost::reset() is the place to do this type of work.
Attachments
Patch (10.71 KB, patch)
2010-11-17 06:40 PST, Satish Sampath 		no flags
DetailsFormatted DiffDiff
Patch (9.45 KB, patch)
2010-11-17 06:52 PST, Satish Sampath 		jorlow: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Satish Sampath
Comment 1 2010-11-17 06:40:18 PST
Created attachment 74104 [details] Patch
Satish Sampath
Comment 2 2010-11-17 06:52:42 PST
Created attachment 74107 [details] Patch
Jeremy Orlow
Comment 3 2010-11-17 07:10:54 PST
Comment on attachment 74107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74107&action=review r=me > WebKitTools/DumpRenderTree/chromium/WebViewHost.cpp:1174 > + if (m_speechInputControllerMock.get()) don't need .get()
Satish Sampath
Comment 4 2010-11-17 07:17:36 PST
Committed r72206: <http://trac.webkit.org/changeset/72206>
Mihai Parparita
Comment 5 2010-11-17 09:39:52 PST
Committed r72214: <http://trac.webkit.org/changeset/72214>
Mihai Parparita
Comment 6 2010-11-17 09:41:31 PST
(In reply to comment #5) > Committed r72214: <http://trac.webkit.org/changeset/72214> Oops, that wasn't supposed to happen (ChangeLog got merged wrong, didn't notice before using webkit-patch land)
Note You need to log in before you can comment on or make changes to this bug.