Bug 49656 – [v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[anton muhin]

Alexander is tracking it down, for now just disabling the test

[Alexander Pavlov (apavlov)]

Seems related to the bug 33193 patch by [e-mail], which explicitly cancels HasIndexGetter for WebKitCSSTransformValue (CodeGeneratorV8.pm). The code that manifests the issue is (element.style having "-webkit-transform: rotate(90deg)"):

element.style.getPropertyCSSValue("-webkit-transform")[0][0] returns "undefined", while Safari returns the property CSSPrimitiveValue instance on which you can invoke e.g. getFloatValue(CSSPrimitiveValue.CSS_RAD).

I believe [e-mail] may have some insight in this regard.

[Kent Tamura]

I remember V8WebKitCSSTransformValue class inherited something (maybe V8CSSValueList?) at that time and no need to implement index getter functions.  But with the current CodeGeneratorV8.pm, V8WebKitCSSTransformValue inherits nothing.  So my hack in Bug 33193 is not effective now.

We should remove the change of Bug 33193, and implement index getter functions for V8WebKitCSSTransformValue.

[Alexander Pavlov (apavlov)]

Created attachment 74229 [details]
[PATCH] Suggested fix

[anton muhin]

Comment on attachment 74229 [details]
[PATCH] Suggested fix

LGTM, but I cannot r+

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/ChangeLog
        M       LayoutTests/platform/chromium/test_expectations.txt
        M       WebCore/ChangeLog
        M       WebCore/bindings/scripts/CodeGeneratorV8.pm
Committed r72290