Bug 49640

Summary: Rebaseline server: compute diffs client-side
Product: WebKit Reporter: Mihai Parparita <mihaip>
Component: Tools / TestsAssignee: Mihai Parparita <mihaip>
Status: RESOLVED FIXED    
Severity: Normal CC: tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 47761    
Attachments:
Description Flags
Patch tony: review+

Mihai Parparita
Reported 2010-11-16 19:21:24 PST
Rebaseline server: compute diffs client-side
Attachments
Patch (7.18 KB, patch)
2010-11-16 19:23 PST, Mihai Parparita 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mihai Parparita
Comment 1 2010-11-16 19:23:07 PST
Created attachment 74078 [details] Patch
Tony Chang
Comment 2 2010-11-17 08:53:36 PST
Comment on attachment 74078 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=74078&action=review > WebKitTools/Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:241 > + if (currentExpectedImageTest == currentActualImageTest && > + currentExpectedImageTest == testName) { Nit: WebKit style is to put the && on the left of the second line.
Mihai Parparita
Comment 3 2010-11-17 09:43:00 PST
(In reply to comment #2) > Nit: WebKit style is to put the && on the left of the second line. Fixed before landing. This got landed as http://trac.webkit.org/changeset/72214, but due to a bad merge in the ChangeLog (my entry didn't end up at the top) didn't get attached to this bug in the commit.
Note You need to log in before you can comment on or make changes to this bug.