Bug 49634 – Make overflow guards in WTF::String::utf8 explicit

• Component: Web Template Framework
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Make overflow guards in WTF::String::utf8 explicit

[David Kilzer (:ddkilzer)]

Created attachment 74071 [details]
Patch

[David Kilzer (:ddkilzer)]

<rdar://problem/8675768>

[Darin Adler]

Comment on attachment 74071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74071&action=review

> JavaScriptCore/wtf/text/WTFString.cpp:700
> +    if (length > numeric_limits<unsigned>::max() / 3)

If we changed the type of the local variable length to size_t instead of unsigned, then this could just check against size_t instead of unsigned, giving us a higher limit on 64-bit platforms.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 74071 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=74071&action=review
> 
> > JavaScriptCore/wtf/text/WTFString.cpp:700
> > +    if (length > numeric_limits<unsigned>::max() / 3)
> 
> If we changed the type of the local variable length to size_t instead of unsigned, then this could just check against size_t instead of unsigned, giving us a higher limit on 64-bit platforms.

Thanks.  I filed Bug 49637.

[David Kilzer (:ddkilzer)]

Committed r72209: <http://trac.webkit.org/changeset/72209>