Bug 49630 – Move Position::EditingBoundaryCrossingRule to a new header file

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin (Ben) Kalman]

Move Position::EditingBoundaryCrossingRule to a new header file

[Benjamin (Ben) Kalman]

Created attachment 74051 [details]
Patch

[Benjamin (Ben) Kalman]

fyi this is a follow up from https://bugs.webkit.org/show_bug.cgi?id=48658

[Tony Chang]

Comment on attachment 74051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74051&action=review

You also want to add the new file to the various build files: GNUmakefile.am, WebCore.gypi, WebCore.pro, WebCore.vcproj/WebCore.vcproj, and WebCore.xcodeproj/project.pbxproj.  I think it won't compile if you don't add it to the xcode project.

> WebCore/editing/EditingBoundary.h:43
> +#endif /* EditingBoundary_h */

The comment should be //, not /* */

[Benjamin (Ben) Kalman]

Dumb question, but is there an easier way to add a file than manually changing 5 files..?

[Darin Adler]

(In reply to comment #4)
> Dumb question, but is there an easier way to add a file than manually changing 5 files..?

Not a dumb question at all. At the moment the answer is no, but we’re hoping someone will find a way to fix that.

[Benjamin (Ben) Kalman]

Created attachment 74456 [details]
Patch

[Benjamin (Ben) Kalman]

> Not a dumb question at all. At the moment the answer is no, but we’re hoping someone will find a way to fix that.

Yes, that would be nice.

[WebKit Review Bot]

Comment on attachment 74456 [details]
Patch

Rejecting patch 74456 from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[Tony Chang]

Comment on attachment 74456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74456&action=review

> WebCore/WebCore.vcproj/WebCore.vcproj:46080
>  				>
> +			<File

You're missing a </File>

[Benjamin (Ben) Kalman]

Created attachment 74457 [details]
Patch

Comment on attachment 74457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74457&action=review

> WebCore/editing/EditingBoundary.h:2
> + * Copyright (c) 2010 Google Inc. All rights reserved.

It is inappropriate to assign yourself copyright in code that you are merely moving.

[Tony Chang]

Comment on attachment 74457 [details]
Patch

Removing from cq based on mitz's comment.

[Tony Chang]

Created attachment 74570 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 74570 [details]
Patch for landing

Rejecting patch 74570 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 74570]" exit_code: 2
Last 500 characters of output:
ILED -- saving rejects to file WebCore/WebCore.xcodeproj/project.pbxproj.rej
patching file WebCore/dom/Position.cpp
patching file WebCore/dom/Position.h
patching file WebCore/editing/DeleteSelectionCommand.cpp
patching file WebCore/editing/EditingBoundary.h
patching file WebCore/editing/visible_units.cpp
patching file WebCore/editing/visible_units.h
patching file WebCore/rendering/RenderObject.cpp

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6363012

[Benjamin (Ben) Kalman]

Created attachment 74827 [details]
Patch

[Darin Adler]

Comment on attachment 74827 [details]
Patch

Seems good to be in a separate file. Not sure it’s good that the file’s name is different from the enum type’s name, though. I would have made them the same.

[WebKit Commit Bot]

Comment on attachment 74827 [details]
Patch

Clearing flags on attachment: 74827

Committed r72777: <http://trac.webkit.org/changeset/72777>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/72777 might have broken GTK Linux 64-bit Debug