Bug 49623

Summary: profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
Product: WebKit Reporter: webkittenghui
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benm, commit-queue, jorlow, steveblock, ztenghui
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Linux   
Attachments:
Description Flags
proposed patch none

webkittenghui
Reported 2010-11-16 14:13:49 PST
With changeset r71515, 2 functions profileCallback and profileEndCallback get added with guarded in the .idl file. But not the V8ConsoleCustom.cpp. This will cause android build break. I will have a patch shortly submit for review.
Attachments
proposed patch (1.40 KB, patch)
2010-11-16 15:10 PST, webkittenghui 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
webkittenghui
Comment 1 2010-11-16 15:10:40 PST
Created attachment 74046 [details] proposed patch Just a compiling error fix. Thanks for reviewing.
Jeremy Orlow
Comment 2 2010-11-17 06:27:10 PST
Comment on attachment 74046 [details] proposed patch r=me
WebKit Commit Bot
Comment 3 2010-11-17 09:54:11 PST
The commit-queue encountered the following flaky tests while processing attachment 74046 [details]: inspector/styles-iframe.html Please file bugs against the tests. These tests were authored by loislo@chromium.org, pfeldman@chromium.org, and yurys@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2010-11-17 09:56:52 PST
Comment on attachment 74046 [details] proposed patch Clearing flags on attachment: 74046 Committed r72216: <http://trac.webkit.org/changeset/72216>
WebKit Commit Bot
Comment 5 2010-11-17 09:56:58 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.