Bug 49617

Summary:

[Chromium] Resize initiated by renderer.

Product:

WebKit

Reporter:

Jonathan Backer <backer>

Component:

New Bugs

Assignee:

Jonathan Backer <backer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kbr, nduca, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Jonathan Backer 2010-11-16 13:16:32 PST

[Chromium] Resize initiated by renderer.

Comment 1 Jonathan Backer 2010-11-16 13:21:11 PST

Created attachment 74033 [details]
Patch

Comment 2 WebKit Review Bot 2010-11-16 13:23:55 PST

Attachment 74033 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1
WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Jonathan Backer 2010-11-16 13:27:56 PST

Created attachment 74034 [details]
Patch

Comment 4 Kenneth Russell 2010-11-16 13:32:25 PST

Comment on attachment 74034 [details]
Patch

Looks good assuming it's been tested on the other platforms.

Comment 5 Jonathan Backer 2010-11-16 13:38:10 PST

It doesn't change the path on OSX. I've tested it on Linux. Nat's tested it on Windows. For all platforms other than OSX, it currently terminates in a NOP in the gl_context level.  Additional Chromium patches will add implementations for different platforms. Then we can ditch the NOP.

Comment 6 WebKit Commit Bot 2010-11-17 04:20:10 PST

Comment on attachment 74034 [details]
Patch

Clearing flags on attachment: 74034

Committed r72192: <http://trac.webkit.org/changeset/72192>

Comment 7 WebKit Commit Bot 2010-11-17 04:20:16 PST

All reviewed patches have been landed.  Closing bug.