Bug 49617

Summary: [Chromium] Resize initiated by renderer.
Product: WebKit Reporter: Jonathan Backer <backer>
Component: New BugsAssignee: Jonathan Backer <backer>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Backer
Reported 2010-11-16 13:16:32 PST
[Chromium] Resize initiated by renderer.
Attachments
Patch (1.33 KB, patch)
2010-11-16 13:21 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Patch (1.34 KB, patch)
2010-11-16 13:27 PST, Jonathan Backer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Backer
Comment 1 2010-11-16 13:21:11 PST
Created attachment 74033 [details] Patch
WebKit Review Bot
Comment 2 2010-11-16 13:23:55 PST
Attachment 74033 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1 WebKit/chromium/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Jonathan Backer
Comment 3 2010-11-16 13:27:56 PST
Created attachment 74034 [details] Patch
Kenneth Russell
Comment 4 2010-11-16 13:32:25 PST
Comment on attachment 74034 [details] Patch Looks good assuming it's been tested on the other platforms.
Jonathan Backer
Comment 5 2010-11-16 13:38:10 PST
It doesn't change the path on OSX. I've tested it on Linux. Nat's tested it on Windows. For all platforms other than OSX, it currently terminates in a NOP in the gl_context level. Additional Chromium patches will add implementations for different platforms. Then we can ditch the NOP.
WebKit Commit Bot
Comment 6 2010-11-17 04:20:10 PST
Comment on attachment 74034 [details] Patch Clearing flags on attachment: 74034 Committed r72192: <http://trac.webkit.org/changeset/72192>
WebKit Commit Bot
Comment 7 2010-11-17 04:20:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.