Bug 49617 - [Chromium] Resize initiated by renderer.
Summary: [Chromium] Resize initiated by renderer.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jonathan Backer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-16 13:16 PST by Jonathan Backer
Modified: 2010-11-17 04:20 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.33 KB, patch)
2010-11-16 13:21 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2010-11-16 13:27 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Backer 2010-11-16 13:16:32 PST
[Chromium] Resize initiated by renderer.
Comment 1 Jonathan Backer 2010-11-16 13:21:11 PST
Created attachment 74033 [details]
Patch
Comment 2 WebKit Review Bot 2010-11-16 13:23:55 PST
Attachment 74033 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKit/chromium/ChangeLog', u'WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1
WebKit/chromium/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jonathan Backer 2010-11-16 13:27:56 PST
Created attachment 74034 [details]
Patch
Comment 4 Kenneth Russell 2010-11-16 13:32:25 PST
Comment on attachment 74034 [details]
Patch

Looks good assuming it's been tested on the other platforms.
Comment 5 Jonathan Backer 2010-11-16 13:38:10 PST
It doesn't change the path on OSX. I've tested it on Linux. Nat's tested it on Windows. For all platforms other than OSX, it currently terminates in a NOP in the gl_context level.  Additional Chromium patches will add implementations for different platforms. Then we can ditch the NOP.
Comment 6 WebKit Commit Bot 2010-11-17 04:20:10 PST
Comment on attachment 74034 [details]
Patch

Clearing flags on attachment: 74034

Committed r72192: <http://trac.webkit.org/changeset/72192>
Comment 7 WebKit Commit Bot 2010-11-17 04:20:16 PST
All reviewed patches have been landed.  Closing bug.