Bug 49575
| Summary: | webkit-patch blows up when the first line of ChangeLog is a blank line | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abarth, dpranke, eric, kling, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Ryosuke Niwa
When there is a blank line at the beginning of ChangeLog, webkit-patch crashes with the following stack trace:
Total errors found: 0 in 8 files
Traceback (most recent call last):
File "WebKitTools/Scripts/webkit-patch", line 70, in <module>
main()
File "WebKitTools/Scripts/webkit-patch", line 65, in main
WebKitPatch(__file__).main()
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 43, in execute
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 61, in run
File "/co/webkit/WebKitTools/Scripts/webkitpy/tool/steps/preparechangelog.py", line 54, in _ensure_bug_url
AttributeError: 'NoneType' object has no attribute 'bug_id'
It should print out more user-friendly message or remove leading blank lines.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
*** This bug has been marked as a duplicate of bug 45988 ***