Bug 49559

Summary: DOMWindow.getComputedStyle pseudo element argument lacks ConvertUndefinedOrNullToNullString
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: CSSAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2010-11-15 13:08:42 PST
Per MDC, it "must be null (or not specified) for regular elements." As far as I can tell, this makes no difference in practice, because "null" and "undefined" are not pseudo element names, and don't even start with ":". But it seems cleaner not to pass them to DOM code.
Attachments
proposed patch (1.25 KB, patch)
2010-11-15 13:11 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-11-15 13:11:01 PST
Created attachment 73924 [details] proposed patch
Darin Adler
Comment 2 2010-11-15 13:13:52 PST
Comment on attachment 73924 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73924&action=review > WebCore/ChangeLog:8 > + No observable change in behavior, so no tests. Why do this if there is no observable change in behavior?
Darin Adler
Comment 3 2010-11-15 13:14:44 PST
Comment on attachment 73924 [details] proposed patch Maybe we can change the default some day. I can’t remember how this relates to the similar properties in WebIDL.
Alexey Proskuryakov
Comment 4 2010-11-15 13:20:55 PST
Comment on attachment 73924 [details] proposed patch Well, basically it's just that I was surprised and confused to see "null" and "undefined" passed to DOM code when debugging.
WebKit Commit Bot
Comment 5 2010-11-15 13:52:33 PST
Comment on attachment 73924 [details] proposed patch Clearing flags on attachment: 73924 Committed r72036: <http://trac.webkit.org/changeset/72036>
WebKit Commit Bot
Comment 6 2010-11-15 13:52:38 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.