Bug 49542

Summary: [Qt][WK2] Avoid polling in WebKitTestRunner
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: WebKit2Assignee: Andras Becsi <abecsi>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, kling, ossy
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
proposed patch none

Andras Becsi
Reported 2010-11-15 07:25:36 PST
In the Qt implementation of TestController we are currently using a polling mechanism to check whether the condition is met. By refactoring RunUntilConditionLoop to avoid polling we can make the WK2 testing session about 10-15% faster and decrease random flackyness resulting from timing skew.
Attachments
proposed patch (7.10 KB, patch)
2010-11-15 07:48 PST, Andras Becsi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andras Becsi
Comment 1 2010-11-15 07:48:57 PST
Created attachment 73894 [details] proposed patch
Andreas Kling
Comment 2 2010-11-15 13:19:06 PST
Comment on attachment 73894 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=73894&action=review Much better, r=me! > WebKitTools/ChangeLog:8 > + Make the WK2 testing session about 10-15% faster and decrease random flackyness s/flackyness/flakiness/
Andras Becsi
Comment 3 2010-11-15 13:36:54 PST
(In reply to comment #2) > s/flackyness/flakiness/ Fixed and committed in r72031: <http://trac.webkit.org/changeset/72031> Closing bug.
Andras Becsi
Comment 4 2010-11-15 13:37:27 PST
Comment on attachment 73894 [details] proposed patch Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.