Bug 49519

Summary: check-webkit-style unit tests has some duplicate boilerplate code.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, eric, hamaji, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 49513    
Bug Blocks:    
Attachments:
Description Flags
Patch hamaji: review+, levin: commit-queue-

David Levin
Reported 2010-11-14 16:08:42 PST
Duplicate code is bad.
Attachments
Patch (21.20 KB, patch)
2010-12-16 08:19 PST, David Levin 		hamaji: review+
levin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-11-14 16:09:37 PST
See https://bugs.webkit.org/show_bug.cgi?id=49513#c2
David Levin
Comment 2 2010-12-16 08:19:57 PST
Created attachment 76771 [details] Patch
Shinichiro Hamaji
Comment 3 2010-12-16 09:28:48 PST
Comment on attachment 76771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76771&action=review Looks good. > WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2869 > + Do we need this blank line?
David Levin
Comment 4 2010-12-16 09:29:46 PST
Comment on attachment 76771 [details] Patch Will address feedback and land.
David Levin
Comment 5 2010-12-16 10:45:54 PST
Committed r74200: <http://trac.webkit.org/changeset/74200>
WebKit Review Bot
Comment 6 2010-12-16 15:39:38 PST
http://trac.webkit.org/changeset/74200 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.