Summary: | check-webkit-style unit tests has some duplicate boilerplate code. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Levin <levin> | ||||
Component: | Tools / Tests | Assignee: | David Levin <levin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, dbates, eric, hamaji, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 49513 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
David Levin
2010-11-14 16:08:42 PST
Created attachment 76771 [details]
Patch
Comment on attachment 76771 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=76771&action=review Looks good. > WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2869 > + Do we need this blank line? Comment on attachment 76771 [details]
Patch
Will address feedback and land.
Committed r74200: <http://trac.webkit.org/changeset/74200> http://trac.webkit.org/changeset/74200 might have broken Leopard Intel Debug (Tests) |