Bug 49519 - check-webkit-style unit tests has some duplicate boilerplate code.
Summary: check-webkit-style unit tests has some duplicate boilerplate code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 49513
Blocks:
  Show dependency tree / graph
 
Reported: 2010-11-14 16:08 PST by David Levin
Modified: 2010-12-16 15:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (21.20 KB, patch)
2010-12-16 08:19 PST, David Levin 		hamaji: review+
levin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2010-11-14 16:08:42 PST 
Duplicate code is bad.
Comment 1 David Levin 2010-11-14 16:09:37 PST 
See https://bugs.webkit.org/show_bug.cgi?id=49513#c2
Comment 2 David Levin 2010-12-16 08:19:57 PST 
Created attachment 76771 [details]
Patch
Comment 3 Shinichiro Hamaji 2010-12-16 09:28:48 PST 
Comment on attachment 76771 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76771&action=review

Looks good.

> WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:2869
> +

Do we need this blank line?
Comment 4 David Levin 2010-12-16 09:29:46 PST 
Comment on attachment 76771 [details]
Patch

Will address feedback and land.
Comment 5 David Levin 2010-12-16 10:45:54 PST 
Committed r74200: <http://trac.webkit.org/changeset/74200>
Comment 6 WebKit Review Bot 2010-12-16 15:39:38 PST 
http://trac.webkit.org/changeset/74200 might have broken Leopard Intel Debug (Tests)