Bug 49517

Summary: [BREWMP] Replace MALLOC, FREE and REALLOC macros with IEnv
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 48597    
Attachments:
Description Flags
Patch eric: review-

Kwang Yul Seo
Reported 2010-11-14 15:48:48 PST
MALLOC, FREE and REALLOC macros are prohibited in Mod1. Use IEnv interface to allocate and free memory.
Attachments
Patch (2.59 KB, patch)
2010-11-14 15:50 PST, Kwang Yul Seo 		eric: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-11-14 15:50:41 PST
Created attachment 73861 [details] Patch
Patrick R. Gansterer
Comment 2 2010-11-21 14:30:52 PST
Comment on attachment 73861 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73861&action=review > JavaScriptCore/wtf/brew/SystemMallocBrew.h:39 > + IEnv* env; > + int result = env_GetCurrent(&env); > + ASSERT_UNUSED(result, result == AEE_SUCCESS); You do the same code 4 times. Seams to be a good candidate for an extra functon. Is it possible to cache IEnv? Do we get an different IEnv for every call/thread/process?
Eric Seidel (no email)
Comment 3 2010-12-10 01:35:22 PST
Comment on attachment 73861 [details] Patch YEah. please add a helper function. Like currentIEnv() or similar.
Kwang Yul Seo
Comment 4 2012-07-26 05:18:51 PDT
Brew MP port is no longer maintained.
Note You need to log in before you can comment on or make changes to this bug.