Bug 49515

Summary: [Qt] Focus ring does not show on focused links.
Product: WebKit Reporter: Yael <yael>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: benjamin, commit-queue, ossy, tonikitoo
Priority: P4 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch none

Description Yael 2010-11-14 14:40:00 PST
After http://trac.webkit.org/changeset/69766 the focus ring on links is no longer visible in Qt.
The reason is that Qt always returned true in RenderTheme::supportsFocusRing(), but until r69766, we did not check that for links.
Qt draws its own focus ring for controls that it draws, but not for links.
A patch is coming soon.
Comment 1 Yael 2010-11-14 14:53:53 PST
Created attachment 73858 [details]
Patch

RenderTheme::supportsFocusRing should check the style appearance before it decides if to return true or false.
Comment 2 Antonio Gomes 2010-11-14 16:15:53 PST
Comment on attachment 73858 [details]
Patch

It would be nice if Ossy could check it on the bots, so it does not fail due to font differences.
Comment 3 Yael 2010-11-14 16:39:51 PST
Antonio, thanks for the review.
Ossy, could you please check that?
thanks,
Comment 4 Csaba Osztrogon√°c 2010-11-15 04:59:51 PST
(In reply to comment #3)
> Antonio, thanks for the review.
> Ossy, could you please check that?
> thanks,

Done, it works for me. Next time you can check it yourself with our Q-BAT:
http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine
Comment 5 Csaba Osztrogon√°c 2010-11-15 05:00:07 PST
Comment on attachment 73858 [details]
Patch

cq+
Comment 6 Yael 2010-11-15 05:15:59 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Antonio, thanks for the review.
> > Ossy, could you please check that?
> > thanks,
> 
> Done, it works for me. Next time you can check it yourself with our Q-BAT:
> http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine

Thanks, Ossy.
Comment 7 WebKit Commit Bot 2010-11-15 05:32:35 PST
Comment on attachment 73858 [details]
Patch

Clearing flags on attachment: 73858

Committed r72004: <http://trac.webkit.org/changeset/72004>
Comment 8 WebKit Commit Bot 2010-11-15 05:32:42 PST
All reviewed patches have been landed.  Closing bug.