Bug 49512

Summary:

check-webkit-style function detection and the line count style checks should be separate.

Product:

WebKit

Reporter:

David Levin <levin>

Component:

Tools / Tests

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cjerdonek, commit-queue, hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
The same patch but ignoring all space changes. (git diff -w)	none

David Levin

Reported 2010-11-14 10:55:46 PST

As I add more checks related to function state, it seemed to made sense to separate the checks from the function detection. It seemed odd that the function was named check_for_function_lengths but it was also setting up the FunctionState that I wanted to use elsewhere.

Attachments
Patch (11.71 KB, patch) 2010-11-14 10:59 PST, David Levin	no flags	Details Formatted Diff Diff
The same patch but ignoring all space changes. (git diff -w) (9.38 KB, patch) 2010-11-14 11:06 PST, David Levin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Levin

Comment 1 2010-11-14 10:59:16 PST

Created attachment 73853 [details] Patch

David Levin

Comment 2 2010-11-14 11:06:59 PST

Created attachment 73854 [details] The same patch but ignoring all space changes. (git diff -w) I'm adding this patch because the real patch makes the changes look much bigger than they are. Due to some code rearrangement, I was able to change to a "fail fast" pattern in several places and unindent code and this looks like big changes.

Shinichiro Hamaji

Comment 3 2010-11-14 11:36:23 PST

Comment on attachment 73853 [details] Patch Looks good.

WebKit Commit Bot

Comment 4 2010-11-14 11:58:54 PST

The commit-queue encountered the following flaky tests while processing attachment 73853 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 5 2010-11-14 11:59:54 PST

Comment on attachment 73853 [details] Patch Clearing flags on attachment: 73853 Committed r71986: <http://trac.webkit.org/changeset/71986>

WebKit Commit Bot

Comment 6 2010-11-14 12:00:00 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.