Bug 49443

Summary: cpp.py needs some tidying.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, hamaji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch abarth: review+, abarth: commit-queue-

David Levin
Reported 2010-11-12 07:16:52 PST
It probably could use more than what I did, but I just adjusted an area where I've been working.
Attachments
Patch (4.34 KB, patch)
2010-11-12 07:19 PST, David Levin 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-11-12 07:19:02 PST
Created attachment 73741 [details] Patch
Adam Barth
Comment 2 2010-11-12 10:07:48 PST
Comment on attachment 73741 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review Looks good, but there's a typo in you ChangeLog. >:-) > WebKitTools/ChangeLog:9 > + Fix parametere ordering for iteratively_replace_matches_with_char parametere ? > WebKitTools/Scripts/webkitpy/style/checkers/cpp.py:1205 > - if not body_found: > + else: Woah
David Levin
Comment 3 2010-11-12 10:21:06 PST
(In reply to comment #2) > (From update of attachment 73741 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=73741&action=review > > Looks good, but there's a typo in you ChangeLog. >:-) I can't believe you cq- for that! Oh wait a minute.... Fixed and committed. :) http://trac.webkit.org/changeset/71926
Note You need to log in before you can comment on or make changes to this bug.