Bug 49405

Summary: [chromium] Support letter spacing and fix whitespace wrapping on linux
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: agl, commit-queue, simonjam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

James Simonsen
Reported 2010-11-11 14:07:27 PST
[chromium] Support letter spacing and fix whitespace wrapping on linux
Attachments
Patch (98.24 KB, patch)
2010-11-11 14:29 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch (97.76 KB, patch)
2010-11-11 15:05 PST, James Simonsen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2010-11-11 14:29:34 PST
Created attachment 73663 [details] Patch
James Simonsen
Comment 2 2010-11-11 14:34:36 PST
Hi Adam, You seem to be most familiar with this code. Could I bother you to LGTM it and then I'll find an R+? Thanks.
Adam Langley
Comment 3 2010-11-11 14:41:40 PST
Comment on attachment 73663 [details] Patch LGTM. Thanks for this! Some WK folks might question the duplication of code in setGlyphXPositions but, in my opinion, it's below the granularity of a function in C, so it's fine by me.
Tony Chang
Comment 4 2010-11-11 14:47:59 PST
Comment on attachment 73663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73663&action=review > WebCore/platform/graphics/chromium/FontLinux.cpp:500 > + if (i+1 >= m_item.num_glyphs || m_item.attributes[i+1].clusterStart) Nit: spaces around the +s.
James Simonsen
Comment 5 2010-11-11 15:05:34 PST
Created attachment 73669 [details] Patch
WebKit Commit Bot
Comment 6 2010-11-11 22:01:59 PST
The commit-queue encountered the following flaky tests while processing attachment 73669 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html Please file bugs against the tests. These tests were authored by dumi@chromium.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2010-11-11 22:04:26 PST
Comment on attachment 73669 [details] Patch Clearing flags on attachment: 73669 Committed r71887: <http://trac.webkit.org/changeset/71887>
WebKit Commit Bot
Comment 8 2010-11-11 22:04:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.