Bug 49373 – [Qt] Add an API for informing the actual visible contents rect to WebCore

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Kenneth Rohde Christiansen]

Used in combination with tiling and resizesToContents.

[Kenneth Rohde Christiansen]

Created attachment 73592 [details]
Patch

[Early Warning System Bot]

Attachment 73592 [details] did not build on qt:
Build output: http://queues.webkit.org/results/5517080

[Andreas Kling]

Comment on attachment 73592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73592&action=review

> WebKit/qt/Api/qwebpage.h:283
> +    void informVisibleContentsRect(const QRect& rect) const;

I don't like this name at all, can we find a better word than "inform"?

setVisibleContentsRect?
forceVisibleContentsRect?
overrideVisibleContentsRect?

[Kenneth Rohde Christiansen]

Created attachment 73595 [details]
Patch

You win!

[Andreas Kling]

Comment on attachment 73595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73595&action=review

r=me, I'll land it for you (once the WebCore change is in) with fixed ChangeLog.

> WebKit/qt/ChangeLog:9
> +        (QWebPage::informVisibleContentsRect):

Somebody forgot to regen the ChangeLog ;)

[Early Warning System Bot]

Attachment 73595 [details] did not build on qt:
Build output: http://queues.webkit.org/results/5460099

[Andreas Kling]

Committed r71806: <http://trac.webkit.org/changeset/71806>

[Ademar Reis]

What about updating the symbian .def files with this new API?
(I don't know or have the tools necessary to update the .def files)

[Misha]

Created attachment 78418 [details]
Fix for def file for symbian winscw

I updated .def file for symbian winscw build. ARM build looks ok.

[Kenneth Rohde Christiansen]

Comment on attachment 78418 [details]
Fix for def file for symbian winscw

What does this ABSENT mean? The method was removed from the branch?

[Kenneth Rohde Christiansen]

(In reply to comment #10)
> (From update of attachment 78418 [details])
> What does this ABSENT mean? The method was removed from the branch?

I mean ViewportConfiguration was renamed long ago, can't those lines be removed instead? just wondering...

[Laszlo Gombos]

Proposed patch looks good to me for 2.1 (and likely for 2.2); not for trunk obviously. r=me.

Kenneth, ABSENT is a simple way to ensure that there are no holes in the ordinal numbers - otherwise one would have to reuse the ordinal numbers for new symbols, which could be confusing for clients.

[Kenneth Rohde Christiansen]

OK, thanks for the explanation!