Bug 49363

Summary: fix missing 'pid' argument for http lockfile checking on win32
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, galpeter, michaeln, ossy, rgabor, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2010-11-10 20:04:17 PST
fix missing 'pid' argument for http lockfile checking on win32
Attachments
Patch (1.48 KB, patch)
2010-11-10 20:04 PST, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-11-10 20:04:51 PST
Created attachment 73574 [details] Patch
Eric Seidel (no email)
Comment 2 2010-11-10 21:43:11 PST
Comment on attachment 73574 [details] Patch Makes sense. :) Can't we test this though? Or was it already failing a test on win32?
Dirk Pranke
Comment 3 2010-11-11 13:33:16 PST
I haven't actually tried this on windows, but there is an existing test in executive_unittest that should've keeled over. Of course, we can't run much of test-webkitpy on windows, so this test may not actually be running. I will verify it locally.
Michael Nordman
Comment 4 2010-11-11 13:37:49 PST
I've run this patch on windows. Definitely fixes a problem with starting the http server when running layout tests.
Dirk Pranke
Comment 5 2010-11-11 13:56:56 PST
Okay, I've verified that the test did fail prior to the patch and does pass post-patch. Given that Michael has verified that it actually fixes NRWT as well :), we're good to go.
Dirk Pranke
Comment 6 2010-11-11 14:52:50 PST
Comment on attachment 73574 [details] Patch Clearing flags on attachment: 73574 Committed r71854: <http://trac.webkit.org/changeset/71854>
Dirk Pranke
Comment 7 2010-11-11 14:52:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.