Bug 49347

Summary: Push m_viewSize down to DrawingAreaProxy base class
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: WebKit2Assignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, aroben, eric, simon.fraser, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Simon Fraser (smfr)
Reported 2010-11-10 14:40:43 PST
Some cleanup coming.
Attachments
Patch (9.37 KB, patch)
2010-11-10 14:52 PST, Simon Fraser (smfr) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-11-10 14:52:49 PST
Created attachment 73544 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-11-10 14:55:24 PST
Comment on attachment 73544 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73544&action=review > WebKit2/UIProcess/DrawingAreaProxy.h:57 > + WebCore::IntSize size() const { return m_size; } This can return a reference to const. > WebKit2/UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:50 > + IntSize viewSize = size(); This can be a reference to const.
Early Warning System Bot
Comment 3 2010-11-10 15:01:35 PST
Attachment 73544 [details] did not build on qt: Build output: http://queues.webkit.org/results/5511096
Simon Fraser (smfr)
Comment 4 2010-11-10 16:23:06 PST
http://trac.webkit.org/changeset/71780
WebKit Review Bot
Comment 5 2010-11-10 16:56:03 PST
http://trac.webkit.org/changeset/71780 might have broken Qt Linux Release The following tests are not passing: svg/animations/repeatDur-zero.xhtml
Note You need to log in before you can comment on or make changes to this bug.