Bug 49338

Summary: plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, victorw, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

Tony Chang
Reported 2010-11-10 12:44:45 PST
plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
Attachments
Patch (3.62 KB, patch)
2010-11-10 12:47 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.35 KB, patch)
2010-11-10 13:58 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-11-10 12:47:08 PST
Created attachment 73528 [details] Patch
Darin Adler
Comment 2 2010-11-10 13:14:54 PST
Comment on attachment 73528 [details] Patch I suggest sorting as a solution to this sort of thing, rather than the set equality approach.
Tony Chang
Comment 3 2010-11-10 13:58:05 PST
Created attachment 73537 [details] Patch for landing
Tony Chang
Comment 4 2010-11-10 13:58:45 PST
(In reply to comment #2) > (From update of attachment 73528 [details]) > I suggest sorting as a solution to this sort of thing, rather than the set equality approach. Good idea. Done.
WebKit Commit Bot
Comment 5 2010-11-10 15:06:52 PST
The commit-queue encountered the following flaky tests while processing attachment 73537 [details]: compositing/iframes/overlapped-nested-iframes.html Please file bugs against the tests. These tests were authored by simon.fraser@apple.com. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2010-11-10 15:08:25 PST
Comment on attachment 73537 [details] Patch for landing Clearing flags on attachment: 73537 Committed r71776: <http://trac.webkit.org/changeset/71776>
WebKit Commit Bot
Comment 7 2010-11-10 15:08:30 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-11-10 16:22:11 PST
http://trac.webkit.org/changeset/71776 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.