Bug 49336

Summary: [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
jamesr: review+, kbr: commit-queue-
patch: simple fix for the regression kling: review+, zmo: commit-queue-

Kenneth Russell
Reported 2010-11-10 12:30:38 PST
In https://bugs.webkit.org/show_bug.cgi?id=48282 I missed a few places where m_isGLES2 should be tested instead of calling gfx::GetGLImplementation().
Attachments
Patch (2.84 KB, patch)
2010-11-10 12:33 PST, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
patch: simple fix for the regression (1.24 KB, patch)
2010-11-12 11:08 PST, Zhenyao Mo 		kling: review+
zmo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-11-10 12:33:48 PST
Created attachment 73524 [details] Patch
James Robinson
Comment 2 2010-11-10 12:38:41 PST
Comment on attachment 73524 [details] Patch R=me
Kenneth Russell
Comment 3 2010-11-10 19:10:01 PST
Committed r71793: <http://trac.webkit.org/changeset/71793>
Zhenyao Mo
Comment 4 2010-11-12 10:54:51 PST
There is a regression in this patch that causes worlds of webgl render incorrectly in in-process-webgl
Zhenyao Mo
Comment 5 2010-11-12 11:08:26 PST
Created attachment 73762 [details] patch: simple fix for the regression point-size.html should have detected this regression, only unfortunately due to mesa backend issues, this test is ignored in chromium bots.
Andreas Kling
Comment 6 2010-11-12 13:30:31 PST
Comment on attachment 73762 [details] patch: simple fix for the regression r=me
Zhenyao Mo
Comment 7 2010-11-12 13:39:47 PST
Committed r71942: <http://trac.webkit.org/changeset/71942>
Note You need to log in before you can comment on or make changes to this bug.