Bug 49302 – Add a test for form submission by <input type=image>

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

Add a test for form submission by <input type=image>

We have no tests about it!

[Kent Tamura]

Created attachment 73461 [details]
Patch

[Shinichiro Hamaji]

Comment on attachment 73461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73461&action=review

Adding more tests is nice :) I've put two minor comments, please apply them if you like.

> LayoutTests/fast/forms/input-image-submit.html:37
> +        gc();

I think the reason why we need to run gc here isn't so clear. Could you write a few comments?

> LayoutTests/fast/forms/input-image-submit.html:72
> +            testFailed('Normal submission failed: ' + query);

I'd add a function which calls both testFailed and notifyDone.

[Kent Tamura]

Thanks for reviewing.
I have committed the patch with the following changes as http://trac.webkit.org/changeset/71799

(In reply to comment #2)
> > LayoutTests/fast/forms/input-image-submit.html:37
> > +        gc();
> 
> I think the reason why we need to run gc here isn't so clear. Could you write a few comments?

I added a comment.

> > LayoutTests/fast/forms/input-image-submit.html:72
> > +            testFailed('Normal submission failed: ' + query);
> 
> I'd add a function which calls both testFailed and notifyDone.

I made a function for it.