Bug 49277
| Summary: | [chromium] Spelling "autocorrection panel" feature should be available. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jamesr, morrita, schenney, tkent, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 39105 | ||
| Bug Blocks: | |||
Ryosuke Niwa
The following tests are failing on chromium test_shell:
BUG11577 WIN LINUX : editing/spelling/inline_spelling_markers.html = FAIL
BUG11577 WIN LINUX : editing/spelling/spellcheck-attribute.html = FAIL
BUG11577 WIN LINUX : editing/spelling/spelling-linebreak.html = FAIL
BUG11577 WIN LINUX : editing/spelling/spelling-attribute-change.html = FAIL
BUG11577 WIN LINUX : editing/spelling/spelling-attribute-at-child.html = FAIL
BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT
BUGWK45438 : editing/spelling/spelling-backspace-between-lines.html = TEXT
BUGWK45898 : editing/selection/context-menu-on-text.html = TEXT
// Tests added in r69269.
// Apple-Mac port corrects "notationl" to "notational" automatically?
BUG58254 MAC : platform/mac/editing/spelling/autocorrection-delete.html = IMAGE+TEXT
BUG58254 MAC : platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html = IMAGE+TEXT
BUG58254 MAC : platform/mac/editing/spelling/autocorrection-removing-underline.html = IMAGE+TEXT
BUG58254 MAC : platform/mac/editing/spelling/autocorrection-simple.html = IMAGE+TEXT
BUGJAMESR WIN LINUX : editing/spelling/spelling-hasspellingmarker.html = TEXT
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Morrita-san, could you take a look at these failures?
Hajime Morrita
Hi Ryosuke, thank you for the triage!
(In reply to comment #0)
> The following tests are failing on chromium test_shell:
>
> BUG11577 WIN LINUX : editing/spelling/inline_spelling_markers.html = FAIL
> BUG11577 WIN LINUX : editing/spelling/spellcheck-attribute.html = FAIL
> BUG11577 WIN LINUX : editing/spelling/spelling-linebreak.html = FAIL
> BUG11577 WIN LINUX : editing/spelling/spelling-attribute-change.html = FAIL
> BUG11577 WIN LINUX : editing/spelling/spelling-attribute-at-child.html = FAIL
> BUGJAMESR WIN LINUX : editing/spelling/spelling-hasspellingmarker.html = TEXT
These are expected due to Bug 45633. I hope we could enable it on win and linux,
but not done yet because it will impact pixel expectations for editing.
>
> BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT
> BUGWK45898 : editing/selection/context-menu-on-text.html = TEXT
These two looks same. So I'll play with contextClick().
>
> BUGWK45438 : editing/spelling/spelling-backspace-between-lines.html = TEXT
IIRC, this is a real bug (not the bug of DRT) filed at Bug45438.
This is caused by a difference between
NSSpellcheker and hunspell. I'll investigate this after fix Bug 41423, for which I'm refactoring...
>
> // Tests added in r69269.
> // Apple-Mac port corrects "notationl" to "notational" automatically?
> BUG58254 MAC : platform/mac/editing/spelling/autocorrection-delete.html = IMAGE+TEXT
> BUG58254 MAC : platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html = IMAGE+TEXT
> BUG58254 MAC : platform/mac/editing/spelling/autocorrection-removing-underline.html = IMAGE+TEXT
> BUG58254 MAC : platform/mac/editing/spelling/autocorrection-simple.html = IMAGE+TEXT
>
These are expected: We don't have auto-correction feature.
It is only available the next version of Safari.
It looks all un-filed bugs are autocorrection related.
I'm changing the summary to reflect it.
BTW, I think we should wait to implement auto-correction
until seeing the Safari version working to respect their effort.
Stephen Chenney
Test related bugs being marked WontFix. TestExpectations will contain bug if still relevant.