Summary: | Need WebKit2 mechanism for getting the visible page text | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-11-09 13:38:35 PST
Created attachment 73408 [details]
Patch
Comment on attachment 73408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73408&action=review > WebKit2/UIProcess/WebPageProxy.cpp:74 > +void invalidateCallbackMap(HashMap<uint64_t, RefPtr<T> >& map) Could just use T in this template in the places you use RefPtr<T>. Would read nicer and work just as well. > WebKit2/UIProcess/API/C/WKPage.cpp:333 > +void WKPageGetContentsAsString(WKPageRef pageRef, void *context, WKPageGetContentsAsStringFunction callback) Should be void* instead of void *. > WebKit2/WebProcess/WebPage/WebFrame.cpp:248 > + WebFrame* webFrame = static_cast<WebFrameLoaderClient*>(child->loader()->client())->webFrame(); > + builder.append(webFrame->contentsAsString()); Not sure this needs a local variable for webFrame. > WebKit2/WebProcess/WebPage/WebFrame.cpp:250 > + if (child->tree()->nextSibling()) > + builder.append(' '); I would suggest: if (!builder.isEmpty()) builder.append(' '); at the start of the loop instead of this code at the end of the loop. > WebKit2/WebProcess/WebPage/WebFrame.cpp:254 > + > + // FIXME: It may make sense to use toStringPreserveCapacity() here. > + return builder.toString(); The blank line here makes the paragraphing a little strange. Landed in 71678. |