Bug 49267
| Summary: | Review page mentions double-click to add comment, but that doesn't work any more | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Sullivan <sullivan> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | CLOSED WORKSFORME | ||
| Severity: | Normal | CC: | abarth, aroben |
| Priority: | P3 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | OS X 10.6 | ||
John Sullivan
At the top of the review page it says:
Double-click a line or select line numbers to add a comment.
But the double-click technique no longer works. The text at the top of the review page needs to be updated.
It seems like r71607 was intended to change this text, but the old text still appears. Maybe there's a cached version somewhere that needs to be updated?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
I removed the text in a followup commit. You might need to clear your cache to see the new text.
John Sullivan
I do see the new text now, but it wasn't there this morning when I filed this (and others could repro). Anyway, seems fine now, so closing.
Adam Barth
The cache headers on code-review.js seem to be set pretty aggressively. When I make compatibility breaking changes, I bump the version number in the URL. For this change, it didn't seem like much of a rush, so I didn't bump the version number.