Bug 49266

Summary:

Move the find page overlay code to FindController

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sullivan: review+

Description Anders Carlsson 2010-11-09 11:30:44 PST

Move the find page overlay code to FindController

Comment 1 Anders Carlsson 2010-11-09 11:32:08 PST

Created attachment 73394 [details]
Patch

Comment 2 John Sullivan 2010-11-09 11:39:40 PST

Comment on attachment 73394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=73394&action=review

> WebKit2/WebProcess/WebPage/FindController.h:63
> +    // FIXME: This should be private.

It's not clear what "This" is here. It's also worth mentioning why it can't currently be private.

Comment 3 Anders Carlsson 2010-11-09 12:04:26 PST

Committed r71665: <http://trac.webkit.org/changeset/71665>